-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] VoIP Input/Output Device Selection #25966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clickup Task: https://app.clickup.com/t/22bmce2 Description: Creating EE structure for outbound dialing. Refactored VoIPUser.ts and made necessary fields protected. Created VoIPUser or EEVoipClient based on the licensing in SimpleVoipUser Made necessary changes for using the voip client. * Clickup Task: https://app.clickup.com/t/22bmce2 Description: Adding missing file. * Clickup Task: https://app.clickup.com/t/22bmce2 Description: Connector changes for detecting the outbound call. * Clickup Task: https://app.clickup.com/t/22bmce2 Description: Handling review comments.
Conflicts: apps/meteor/client/contexts/CallContext.ts apps/meteor/client/lib/voip/VoIPUser.ts apps/meteor/client/providers/CallProvider/CallProvider.tsx apps/meteor/client/providers/MeteorProvider.tsx
sampaiodiego
previously approved these changes
Jun 24, 2022
KevLehman
changed the title
[NEW] Device Selection
[NEW] VoIP Input/Output Device Selection
Jun 27, 2022
KevLehman
previously approved these changes
Jun 28, 2022
This one, again, will be tested as part of full Outbound Calls feature |
This PR currently has a merge conflict. Please resolve this and then re-add the |
kodiakhq
bot
removed
the
stat: ready to merge
PR tested and approved waiting for merge
label
Jun 28, 2022
aleksandernsilva
requested changes
Jun 28, 2022
apps/meteor/client/sidebar/sections/components/OmnichannelMakeCall.tsx
Outdated
Show resolved
Hide resolved
KevLehman
previously approved these changes
Jun 28, 2022
aleksandernsilva
previously approved these changes
Jun 28, 2022
KevLehman
dismissed stale reviews from aleksandernsilva and themself
via
June 28, 2022 19:40
12a0dc1
aleksandernsilva
approved these changes
Jun 28, 2022
KevLehman
approved these changes
Jun 28, 2022
gabriellsh
added a commit
that referenced
this pull request
Jun 29, 2022
…turbo * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Community Edition Watermark (#25844) [BREAK] remove unused endpoints and restify others (#25889) Chore: add underscore to ddp-streamer [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993) Regression: Fix micro services (#26054) Regression: Fix threads list (#26052) [NEW] VoIP Input/Output Device Selection (#25966) Chore: Account/Profile to TS (#25929)
gabriellsh
added a commit
that referenced
this pull request
Jun 29, 2022
…/clientPackage * 'develop' of github.com:RocketChat/Rocket.Chat: (80 commits) [NEW] Community Edition Watermark (#25844) [BREAK] remove unused endpoints and restify others (#25889) Chore: add underscore to ddp-streamer [IMPROVE] VoIP admin page cleanup: remove unused settings (#25993) Regression: Fix micro services (#26054) Regression: Fix threads list (#26052) [NEW] VoIP Input/Output Device Selection (#25966) Chore: Account/Profile to TS (#25929) Chore: Add missing Swedish livechat translations (#26048) [IMPROVE] Expand the feature set of the new message rendering (#25970) Chore: Bump fuselage and update icon (#26036) [NEW][APPS] Allowing apps to register authenticated routes (#25937) [NEW] Enable outbound calling for EE (#25843) (#25960) Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047) [FIX] Importer fails to download files from URLs with query string params (#25934) [IMPROVE] Moved call hold/unhold to EE (#26007) [NEW] Engagement Metrics - Phase 2 (#25505) Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035) [FIX] Importer files are unnecessarily transferred over the network. (#25919) Chore: test turbo params (#26038) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.